Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cast to string when calling rawurlencode() within Wildcard router #24

Merged
merged 1 commit into from
Dec 16, 2020
Merged

cast to string when calling rawurlencode() within Wildcard router #24

merged 1 commit into from
Dec 16, 2020

Conversation

gkralik
Copy link
Contributor

@gkralik gkralik commented Dec 11, 2020

Q A
Documentation no
Bugfix yes
BC Break yes
New Feature no
RFC no
QA no

Description

The Wildcard router was not casting values to string when calling rawurlencode() during route asembly, leading to a TypeError.

This patch adds an explicit cast when calling the function.

Fixes #23

@weierophinney weierophinney added the Bug Something isn't working label Dec 16, 2020
@weierophinney weierophinney added this to the 3.4.4 milestone Dec 16, 2020
@weierophinney weierophinney merged commit 2c85925 into laminas:3.4.x Dec 16, 2020
@weierophinney weierophinney linked an issue Dec 16, 2020 that may be closed by this pull request
Wildcard: TypeError: rawurlencode() expects parameter 1 to be string, int given #23
Closed
@weierophinney weierophinney mentioned this pull request Dec 16, 2020
Closed
@github-actions github-actions bot mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
3.4.4
Development

Successfully merging this pull request may close these issues.

Wildcard: TypeError: rawurlencode() expects parameter 1 to be string, int given
2 participants
@gkralik @weierophinney